twitchdev / issues

Issue tracker for third party developers.
Apache License 2.0
73 stars 6 forks source link

Get Soundtrack Playlist: invalid ASIN with `data`? #534

Closed BarryCarlyon closed 1 year ago

BarryCarlyon commented 2 years ago

Brief description

Get Soundtrack by playlist ID has incosnsitent behaviour with the rest of helix when the ASIN/PlaylistID is invalid

How to reproduce

twitch api get 'soundtrack/playlist?id=109bd24a-40d0-402d-9f52-bc46e19c9543'

{
  "data": [],
  "error": "Bad Request",
  "message": "invalid ASIN",
  "status": 400
}

Expected behavior

No data in the response it is inconsistent with other Helix endpoints

iProdigy commented 2 years ago

109bd24a-40d0-402d-9f52-bc46e19c9543 is a stationID, not a playlist ASIN (e.g. B08NFD9GVR)

BarryCarlyon commented 2 years ago

@iProdigy correct but the problem here is:

No data in the response it is inconsistent with other Helix endpoints

Not that I passed an invalid ASIN. The "invalid ASIN" is included in the "reproduction steps" to indicate how to get the error of an empty data array which is inconsistent with other Helix endpoints when helix errors

The response should be

{
  "error": "Bad Request",
  "message": "invalid ASIN",
  "status": 400
}

Not

{
  "data": [],
  "error": "Bad Request",
  "message": "invalid ASIN",
  "status": 400
}

I believe you have misread what the purpose of this GitHub bug report is for

iProdigy commented 2 years ago

No data in the response it is inconsistent with other Helix endpoints

Thanks for the clarification - I see what you mean now

Xemdo commented 1 year ago

Soundtrack product and API has been deprecated: https://discuss.dev.twitch.tv/t/withdrawal-of-twitch-api-endpoints-for-soundtrack/46021