twitchdev / issues

Issue tracker for third party developers.
Apache License 2.0
73 stars 6 forks source link

`twitchconAmsterdam2020` badge should be named to `twitchconEU2020` #663

Closed Felanbird closed 1 year ago

Felanbird commented 2 years ago

Brief description In the https://badges.twitch.tv/v1/badges/global/display?language=en endpoint, the badge_key naming for Twitchcon Amsterdam 2020 is out of place.

Expected behavior The badge should follow the existing standard of twitchcon+Year or twitchcon+continent+Year

Screenshots image

Additional context or questions I'm aware this is not a helix API call, but this seems more like something that should be suggested here, as the support people already have enough webui issues to help with. same issue on Helix

thedist commented 2 years ago

Really it's the twitchconEU prefix that's out of place, as It's Twitchcon Europe, not EU. Also, as you've stated yourself this is not part of the Helix API, so isn't appropriate for this github repo/label.

Emilgardis commented 2 years ago

The same is reported from helix

❯ twitch api get chat/badges/global | jq '.data[].set_id | select(. | startswith("twitchcon"))' 

"twitchcon2017"
"twitchcon2018"
"twitchconAmsterdam2020"
"twitchconEU2019"
"twitchconEU2022"
"twitchconNA2019"
"twitchconNA2020"
"twitchconNA2022"

however, this is not the place for feature requests or changes, the uservoice is the place for that.

Felanbird commented 2 years ago

Really it's the twitchconEU prefix that's out of place, as It's Twitchcon Europe, not EU. Also, as you've stated yourself this is not part of the Helix API, so isn't appropriate for this github repo/label.

They are badge keys, they are not markers on the political infastructure of Europe vs EU, it makes perfect sense to take a 2 letter short-form for both NA and EU. It makes way more sense to be be consistently called twitchconEU than it would be to be called twitchconBerlin & twitchconAmsterdam respectively.

the uservoice is the place for that.

No, a support ticket is the correct place, but I don't want to have to reply to a support ticket over the next 3 months like I had to the last time I reported an issue on this.

or changes,

What do you think this is for then?

Emilgardis commented 2 years ago

from the readme:

This repository provides a means for third party developers to report bugs – unexpected errors or flaws – related to Twitch developer products such as the API, Extensions, and PubSub.

I guess it could be a flaw ;)

thedist commented 2 years ago

They are badge keys, they are not markers on the political infastructure of Europe vs EU, it makes perfect sense to take a 2 letter short-form for both NA and EU. It makes way more sense to be be consistently called twitchconEU than it would be to be called twitchconBerlin & twitchconAmsterdam respectively.

Except Twitchcon Europe isn't limited to the EU. the EU is a specific set of countries. For example if there was a Twitchcon in London it would make complete sense for a twitchconLondonYEAR but absolutely no sense for a twitchconEUYEAR for that Twitchcon because the UK isn't in the EU, while it is part of Europe.

Even on Twitch's own internal and external communications they are instructed not to use 'EU' when publicly referencing it and to use Europe instead.

No, a support ticket is the correct place, but I don't want to have to reply to a support ticket over the next 3 months like I had to the last time I reported an issue on this.

This is not a bug, it's a design choice. If you wish to request changes to Twitch's design, especially ones which extend beyond 3rd party integration as you yourself showed a link to a first party endpoint in your original post, then UserVoice is the correct place for feature requests where you can appropriately state your usecase/need for your request.

Felanbird commented 2 years ago

This is not a bug, it's a design choice.

Why did they switch back to the existing standard in 2022 then? Both Amsterdam and Berlin are in Europe, and by proxy of their country, the European Union. It seems very likely that it's a mistake snuck past during Covid review times.

thedist commented 2 years ago

What would be your feature request then for European countries that host a TwitchCon that are not part of the EU? And again in terms of naming schemes there's a disconnect between what the Twitch dev choose for badge names, and Twitch's brand guidelines on TwitchCon that state it's TwitchCon Europe, not TwitchCon EU.

https://twitch.uservoice.com/forums/310213-developers would be the intended place for feature requests.