search

twitchdev / issues

Issue tracker for third party developers.
Apache License 2.0
72 stars 7 forks source link

Version Details gets wiped out when saving Capabilities #876

Closed byte2pixel closed 3 months ago

byte2pixel commented 7 months ago

Brief description All of the information in version details gets obliterated when saving the Capabilities information

How to reproduce Edit the allow list urls for the config page adding or removing some values. image

Click the save button at the bottom of the page: image

Then if you try to leave the page you get a warning about losing data. This warning caused me to click the save button again and then also click the save button in the top section with the radio buttons: image

Expected behavior Everything is saved which it seems to be. However the data on the version details page gets lost and everything is empty. I am then allowed to move to hosted tests and when trying to send a chat message on behalf of the extension I get an error about extension_name is required. This is what lead me to find the bug.

Screenshots Before these steps all of the data here was filled in: image

Additional context or questions @BarryCarlyon also confirmed that this was happening when he tried the same steps.

It only happens when pressing the save button in the radio button section. If I only press the save button at the bottom of the page then it is not wiped out.

BarryCarlyon commented 7 months ago

It only happens when pressing the save button in the radio button section. If I only press the save button at the bottom of the page then it is not wiped out.

if occurs when you use both save buttons on this page in either order.

So if you do top then bottom, It kills version details or if you do bottom then top, It kills version details

basically if you use both save buttons on this page without a reload in btween it can wipe out version details it seems

jbulava commented 7 months ago

Ticketed internally on ANC-3202.

Marenthyu commented 5 months ago

The Name being "Empty" also impacts the Send Extension Chat Message Endpoint, which returns an Error 400 claiming that the extension_name is missing.

I'd argue this should be a Server Error 500 or 412 Precondition Failed as the Name isn't provided by the Client calling this Method, but it is an invalid state for the Extension in the first place, so won't be a problem once the overall issue is solved.

jbulava commented 3 months ago

A fix for this issue has been deployed today.