twitchdev / issues

Issue tracker for third party developers.
Apache License 2.0
72 stars 7 forks source link

Moderator fields is empty for `channel.unban_request.resolve` event if i approve unban request #925

Closed Satont closed 2 months ago

Satont commented 3 months ago

Brief description

For channel.unban_request.resolve moderator fields is empty when status is approved.

How to reproduce

When status approved:

map[broadcaster_user_id:1039971625 broadcaster_user_login:neuropunkenjoyer broadcaster_user_name:neuropunkenjoyer id:b617ad7d-9193-43cf-9ec5-30195d8d7548 moderator_user_id:<nil> moderator_user_login:<nil> moderator_user_name:<nil> resolution_text:<nil> status:approved user_id:783099094 user_login:gguuse user_name:GGuuse]

When status is declined:

map[broadcaster_user_id:1026936836 broadcaster_user_login:fukushined broadcaster_user_name:fukushined id:2b75c21b-f0a6-4596-970e-e695e3052a2d moderator_user_id:1026936836 moderator_user_login:fukushined moderator_user_name:fukushined resolution_text:qwe status:denied user_id:783099094 user_login:gguuse user_name:GGuuse]

Expected behavior

Should not be empty?

Screenshots

Additional context or questions

I'm using webhooks

Durss commented 3 months ago

Also the resolution_text is empty in this case (we get it when refusing the unban request)

JSON example received when approving an unban request:

{
  "metadata": {
    "message_id": "5BJ1m69zP2jxyEZ3_RNOftXyTb3GAPC-bFu6RPsc3XQ=",
    "message_type": "notification",
    "message_timestamp": "2024-03-16T14:06:48.888081598Z",
    "subscription_type": "channel.unban_request.resolve",
    "subscription_version": "beta"
  },
  "payload": {
    "subscription": {
      "id": "8b0c9039-fb7a-436b-b8ae-58bb4bb30d0e",
      "status": "enabled",
      "type": "channel.unban_request.resolve",
      "version": "beta",
      "condition": {
        "broadcaster_user_id": "29961813",
        "moderator_user_id": "29961813"
      },
      "transport": {
        "method": "websocket",
        "session_id": "AgoQPiHVBJs-QCqBxcRQGjDEoRIGY2VsbC1j"
      },
      "created_at": "2024-03-16T14:04:06.8377453Z",
      "cost": 0
    },
    "event": {
      "id": "a89d4d69-5515-4a81-b753-dc878832a38c",
      "broadcaster_user_id": "29961813",
      "broadcaster_user_login": "durss",
      "broadcaster_user_name": "Durss",
      "moderator_user_id": null,
      "moderator_user_login": null,
      "moderator_user_name": null,
      "user_id": "647389082",
      "user_login": "durssbot",
      "user_name": "DurssBot",
      "resolution_text": null,
      "status": "approved"
    }
  }
}
BarryCarlyon commented 3 months ago

So from my testing and this testing:

BarryCarlyon commented 3 months ago

Varation 2)

accept a request "normally" - missing moderator information and resolve text

Seems resolved

I need to retest varion 3). Variation 3 is still broken

BarryCarlyon commented 3 months ago

varation 3 is resolved.

So i think this one is all fixed!