Fix data race around leader handling

twitchscience / kinsumer

Native Go consumer for AWS Kinesis streams.

Other

134 stars 35 forks source link

Fix data race around leader handling #20

Closed dcelasun closed 5 years ago

dcelasun commented 5 years ago

This is a fix for #19, but I'm not 100% sure if the leadership behaviour is correct because the integration tests don't work, neither on master nor with this commit. I've tried go test ./... with kinesalite & dynalite, but the tests never finish and Go kills it at the 10 minute mark.

garethlewin commented 5 years ago

(Merged master into this branch to get the update Travis CI changes.)

garethlewin commented 5 years ago

Ok, next week I will fix the integration tests and we can see what is going on here. Thanks for finding this.

dcelasun commented 5 years ago

@GarethLewin any updates?

garethlewin commented 5 years ago

Sorry for the delay, integration tests are fixed.

dcelasun commented 5 years ago

@GarethLewin turns out fixing the race was much simpler :) This can be merged now.