search

twitchscience / kinsumer

Native Go consumer for AWS Kinesis streams.
Other
134 stars 35 forks source link

use google uuid; add module #46

Closed brenol closed 4 years ago

garethlewin commented 5 years ago

Thanks for this, need to update the travis file so that the right package is pulled. I'll make a separate pr to do a go module build once this is in and works.

mikemoate commented 4 years ago

@brenol @GarethLewin is there anything we can do to help get this PR in?

If not, I'd be happy to put up a new PR (based on this) with the travis file updated. I'd also be happy to help out with enabling the go module build.

We use this library a lot and would love to see it have go modules support.

garethlewin commented 4 years ago

Sorry, I have been very busy lately and this fell off my radar. Not a good reason and I'll make sure to find time soon, in the meantime such a PR would be very useful thanks @mikemoate or just a separate pr that fixes modules.

brenol commented 4 years ago

Hey guys,

I can do those changes no problem. Was a little away for the time being but I can fix the work done on this one.

I did not notice I had to change the travis file so sorry for that. I will fix it later today :)

On Sun, Oct 20, 2019, 10:38 Gareth Lewin notifications@github.com wrote:

Sorry, I have been very busy lately and this fell off my radar. Not a good reason and I'll make sure to find time soon, in the meantime such a PR would be very useful thanks @mikemoate https://github.com/mikemoate or just a separate pr that fixes modules.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/twitchscience/kinsumer/pull/46?email_source=notifications&email_token=ABYAU2OW7SI5CISVMAR4HFLQPRNN3A5CNFSM4I4KQMKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBYKLAA#issuecomment-544253312, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABYAU2PTTUZHLAJY4O2I5NDQPRNN3ANCNFSM4I4KQMKA .

taraspos commented 4 years ago

@brenol any update here? I was waiting for you, but I can create my own PR... This is a couple lines fix.

brenol commented 4 years ago

Ugh, sorry, please get to work on it as I há e been without time. Sorry about that!

On Mon, Oct 28, 2019, 11:24 Taras notifications@github.com wrote:

@brenol https://github.com/brenol any update here? I was waiting for you, but I can create my own PR... This is a couple lines fix.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/twitchscience/kinsumer/pull/46?email_source=notifications&email_token=ABYAU2OSRTUFBKA6UB4REMLQQ3Y2VA5CNFSM4I4KQMKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECNBSSI#issuecomment-546969929, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABYAU2LVYZYHJ7C6QBARGCDQQ3Y2VANCNFSM4I4KQMKA .