search

twitchtv / twirp

A simple RPC framework with protobuf service definitions
https://twitchtv.github.io/twirp/docs/intro.html
Apache License 2.0
7.12k stars 326 forks source link

Should The Constant Version Be Bumped to 8? #309

Closed marwan-at-work closed 3 years ago

marwan-at-work commented 3 years ago

Now that v8 is released, shouldn't this constant be also updated to ensure that generated code and library code are compatible?

Thanks!

marioizquierdo commented 3 years ago

No, it should not be updated because the twirp runtime library was not updated; v7 and v8 are the same. The major version release is for the generator. See the new doc we added with a version compatibility matrix: https://twitchtv.github.io/twirp/docs/version_matrix.html

But, to your point, we should probably update the comment on that constant. Thanks for reporting!

marwan-at-work commented 3 years ago

ah, love that matrix. thanks!