twitchtv / twirp

A simple RPC framework with protobuf service definitions
https://twitchtv.github.io/twirp/docs/intro.html
Apache License 2.0
7.19k stars 326 forks source link

Fasthttp support #366

Closed pjebs closed 2 years ago

wmatveyenko commented 2 years ago

Hi, we would love to help, but we need a bit more detail 😉 .

pjebs commented 2 years ago

Can I make it work with fasthttp which is used behind the scenes in fiber framework?

wmatveyenko commented 2 years ago

Is there a reason why you feel it would not work? We don't specifically test with it, if that is the question you are asking.

pjebs commented 2 years ago

Fasthttp is an alternative to standard net/http package, but is so popular in go community (due to fiber framework)

swiftyspiffy commented 2 years ago

We need more details on specifically what changes you are suggesting and reasoning behind them. I recommend you checkout the code and test it against fasthttp and report back your findings (and potentially any problems you faced). I don't believe fasthttp has been brought up before by other users (beyond the reference here around pooling).