twitchtv / twirp

A simple RPC framework with protobuf service definitions
https://twitchtv.github.io/twirp/docs/intro.html
Apache License 2.0
7.2k stars 326 forks source link

Provide auto-instrumentation for OpenTelemetry standard #370

Closed BrianGreenhill closed 1 year ago

BrianGreenhill commented 2 years ago

First off, thanks so much for twirp!

The OpenTelemetry project has a repo containing autoinstrumenters for widely used packages (like net/http and others). This issue is to track work on creating auto-instrumentation for twirp. I'm interested to hear your thoughts. Is this something you would be open to for this project?

wmatveyenko commented 2 years ago

Thanks for your interest. We would be open to OpenTelemetry support, but it is not something we would actively work on. What changes would it need for hooks / interceptors?

BrianGreenhill commented 2 years ago

It shouldn't require any changes to twirp itself. It can be implemented as a middleware in combination with a server hook. There are some examples in public repos already. One example: https://github.com/chengjiagan/twirp-opentelemetry/

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 60 days with no activity. Remove stale label / comment or this will be closed in 5 days