search

twitchtv / twirp

A simple RPC framework with protobuf service definitions
https://twitchtv.github.io/twirp/docs/intro.html
Apache License 2.0
7.14k stars 327 forks source link

fix issue #371 #372

Closed cloudsinmycoffee closed 1 year ago

cloudsinmycoffee commented 1 year ago

Issue #371:

Description of changes: generator.go in func doJSONRequest was changed from 

    t.P(`  marshaler := &`, t.pkgs["protojson"], `.MarshalOptions{UseProtoNames: true}`)

to 

    t.P(`  marshaler := &`, t.pkgs["protojson"], `.MarshalOptions{UseProtoNames: !s.jsonCamelCase, EmitUnpopulated: !s.jsonSkipDefaults}`)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

github-actions[bot] commented 1 year ago

This PR is stale because it has been open for 60 days with no activity. Remove stale label / comment or this will be closed in 5 days