search

twitchtv / twirp

A simple RPC framework with protobuf service definitions
https://twitchtv.github.io/twirp/docs/intro.html
Apache License 2.0
7.19k stars 326 forks source link

Add larking to list of twrip runtimes #379

Closed emcfarlane closed 1 year ago

emcfarlane commented 1 year ago

Hello, I’ve been working on a service to help use gRPC transcoding. The implicit methods map really neatly over to twirps protocol. In testing it looks good. Error support was added and works but by translating grpc status to twirp errors it doesn’t support all the meta fields and two error codes. Please see test case here: https://github.com/emcfarlane/larking/blob/main/benchmarks/twirp_test.go

Add https://github.com/emcfarlane/larking as a twirp server runtime.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

swiftyspiffy commented 1 year ago

Hello! Apologies for the delay on this.

This is a neat project, but I think for the time being we're not currently adding new personal projects. We'll probably develop a criteria for project submissions at some point, but we've got nothing at the moment.

emcfarlane commented 1 year ago

@swiftyspiffy no worries! Thanks for getting back to me.