search

twitchyliquid64 / usbd-hid

MIT License
87 stars 37 forks source link

Updated byteorder dependency to ~1.4 in macros/Cargo.toml #46

Closed riskable closed 1 year ago

riskable commented 1 year ago

This should fix issues with other crates (e.g. embedded-graphics master branch) that expect a newer version of the byteorder crate. I tested this change and it doesn't appear to impact anything (everything builds just fine 👍).

haata commented 1 year ago

I looked back in git history and the ~1.3 seems to go back to the initial commit. I also ran some basic tests on 1.2.7 that also seemed to work (though nothing extensive).

I think upgrading to 1.4 should be fine.

haata commented 1 year ago

I also ran more tests while doing #47 as GitHub Actions weren't running clippy on this crate...

riskable commented 1 year ago

Thanks for merging this 👍