macros: don't use `>=` in version selector.

twitchyliquid64 / usbd-hid

MIT License

87 stars 37 forks source link

macros: don't use `>=` in version selector. #71

Closed Dirbaio closed 1 month ago

Dirbaio commented 1 month ago

>=0.8.0 matches literally any higher version, with possible breaking changes: 0.8.x, 0.9.x, 1.x, 2.x... This will cause the build of usbd-hid-macros to break when 0.9.0 or higher is relased.

This already happened. -macros v0.6 had >=0.1.2, which broke today when you released v0.8.0, breaking embassy: https://github.com/embassy-rs/embassy/pull/3181 .

twitchyliquid64 commented 1 month ago

Ahhhh whelp, sorry about that. I wasn’t thinking when I updated the package.

twitchyliquid64 commented 1 month ago

Should I yank 0.8.0 and 0.8.1 along with when I release this as 0.8.2?