Fixed memory leak problem

twitter-archive / CocoaSPDY

SPDY for iOS and OS X

Apache License 2.0

2.39k stars 233 forks source link

Fixed memory leak problem #160

Closed yaoxp closed 7 years ago

yaoxp commented 7 years ago

When the nodes number is greater than 4, it will cause memory leaks.

coveralls commented 7 years ago

Coverage increased (+0.05%) to 76.288% when pulling 0561b198a75d933b12045ce5cb2cfc3dec9c21e3 on yaoxp:develop into 9b98410df77fd477da2fae08490f2dbdb5787038 on twitter:develop.

kgoodier commented 7 years ago

Did you find this by inspection or from debugging? This should have been fixed in change https://github.com/twitter/CocoaSPDY/commit/5f9354a, there's even a unit test testAllStreamRemovalDoesNotLeak covering it. Or is there something else I'm missing?

Thanks!

yaoxp commented 7 years ago

I'm sorry I was wrong. I use the master branch of the code. There is no problem in the develop branch.