search

twitter-archive / CocoaSPDY

SPDY for iOS and OS X
Apache License 2.0
2.39k stars 233 forks source link

Invalid SETTINGS frame sent #34

Closed indutny closed 10 years ago

indutny commented 10 years ago

While trying to figure out: https://github.com/indutny/node-spdy/issues/133

I have found that CocoaSPDY sends SETTINGS_INITIAL_WINDOW_SIZE set to 0, is there any particular reasons for this? Or is it just a bug?

indutny commented 10 years ago

Quote from specification:

When the value of SETTINGS_INITIAL_WINDOW_SIZE changes, a receiver MUST adjust the size of all stream flow control windows that it maintains by the difference between the new value and the old value.

Also this probably means that servers that are working with CocoaSPDY are broken and ignoring specification.

goaway commented 10 years ago

Sorry didn't mean to close this - thanks for reporting the issue, I'll be looking into it shortly.

goaway commented 10 years ago

Hey @indutny, thanks for your help in looking into this! It looks like this was caused by a project that was using a SPDYConfiguration object that had all values set to 0. This is confusing and I'll consider changing the result of [[SPDYConfiguration alloc] init] in a future release. The current correct way to utilize default values is to simply not set your own custom configuration, or to base your configuration off the return value of [SPDYConfiguration defaultConfiguration].