search

twitter-archive / CocoaSPDY

SPDY for iOS and OS X
Apache License 2.0
2.39k stars 233 forks source link

Enable better control over Logging #43

Closed blakewatters closed 9 years ago

blakewatters commented 10 years ago

I was frustrated with the inability to control my SPDY logging when DEBUG=1. This pull request makes 2 minor changes to improve the flexibility:

  1. Respects any existing value for SPDY_DEBUG_LOGGING exported to the build environment
  2. If a sharedLogger instance has been configured, it favors that logging interface over the fallback NSLog regardless of the value for SPDY_DEBUG_LOGGING
caniszczyk commented 10 years ago

@goaway any need for this? if not, we should close this PR

kgoodier commented 10 years ago

I think this is a good addition, and it maintains backwards compatibility.

kgoodier commented 9 years ago

This functionality, in a slightly different form, has been merged into the 'develop' branch. See commit https://github.com/twitter/CocoaSPDY/commit/fe8642db31cb580c057cd51c98ec729f778cd54b for details. I believe that change should satisfy the requirements outlined in this pull request, so I'm closing this.