search

twitter-archive / cloudhopper-smpp

Efficient, scalable, and flexible Java implementation of the Short Messaging Peer to Peer Protocol (SMPP)
Other
381 stars 357 forks source link

DefaultSmppServer ignores ExecutorService it's constructed with #63

Closed maciej closed 9 years ago

maciej commented 10 years ago

I've noticed while reading the code of DefaultSmppServer (line 115) that the executor parameter is never used. I'm not sure if this is intended behaviour.

xgp commented 9 years ago

Good catch. The use of the ExecutorService got orphaned with Netty changes. This is no longer relevant in the Netty 4 implementation.