Destroy session in DefaultSmppClient on bind error

twitter-archive / cloudhopper-smpp

Efficient, scalable, and flexible Java implementation of the Short Messaging Peer to Peer Protocol (SMPP)

Other

381 stars 357 forks source link

Destroy session in DefaultSmppClient on bind error #97

Open phyrex1an opened 9 years ago

phyrex1an commented 9 years ago

In case bind fails the caller wont be able to destroy the created session (if any). In the case of DefaultSmppSession this will cause the WindowMonitor of the sendWindow to detect a missing Window.destroy and log an error about this.

This patch destroys the session in cases the session has been created but wont be returned to the caller.

CLAassistant commented 4 years ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Mikael Bung seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}