search

twitter-archive / commons

Twitter common libraries for python and the JVM (deprecated)
http://twitter.github.com/commons
Other
2.1k stars 565 forks source link

Upgrade to pants 0.0.39 #400

Closed jsirois closed 9 years ago

jsirois commented 9 years ago

See the pants changelog here: https://pypi.python.org/pypi/pantsbuild.pants/0.0.39

This pulls in 2 important fixes for commons python:

  1. Fixes broken thrift handling in the run, repl, compile, test and binary goals.
  2. Fixes python thrift stub publishing to work in the setup-py goal.

The python thrift stub publishing fix does require a change to the old publishing scheme where the plain python_library target depending on the python thrift stub code would include that code in its sdist. That arrangment was not generally provably sound (more than one python_library might depend on the thrift stubs in which case both woul publish with the embedded thrift stub code). The new arrangement just requires published python_thrift_libraries have their own setup_py and this change adds those for the 2 python_thrift_libraries that were implicitly published previously.

Some additional BUILD and pants.ini config cleanups are also included.

https://rbcommons.com/s/twitter/r/2530/

jsirois commented 9 years ago

This addresses #394

jsirois commented 9 years ago

Submitted @ https://github.com/twitter/commons/commit/ba861a184d0c178362284ff21996ef6a3a55cc0d