search

twitter-archive / commons

Twitter common libraries for python and the JVM (deprecated)
http://twitter.github.com/commons
Other
2.1k stars 565 forks source link

Update styleguide.md #444

Closed exarus closed 4 years ago

exarus commented 7 years ago

I think that

(a << (8 * n) + 1) | 0xFF is a bit less obvious than: (a << (8 * n + 1)) | 0xFF Because it's a bit harder to guess which has a higher precedence: + or >>. But muck easier to guess that a * has a higher precedence than +. Except that, * is placed left, so even if the reader is confused about the precedence of + and *, than he may just apply those operations one by one from left to right just as they would be with the same precedence.

exarus commented 7 years ago

Is CI build failed because of my style guide recommendation?

exarus commented 6 years ago

Any comments on this? In 2018 the PR still remains valid.

CLAassistant commented 4 years ago

CLA assistant check
All committers have signed the CLA.

grimreaper commented 4 years ago

Thank you for your contribution. Unfortunately, we’re not going to continue maintaining twitter-commons and are archiving all pull requests.