search

twitter-archive / commons

Twitter common libraries for python and the JVM (deprecated)
http://twitter.github.com/commons
Other
2.1k stars 565 forks source link

Drop rbcommons in favor of github reviews. #446

Closed stuhood closed 7 years ago

stuhood commented 7 years ago

Problem

Twitter has decided to move away from RBCommons for external contributions, at least partially because of the improvements to Github reviews... but also due to a unanimous decision from the pantsbuild/pants project to move away from RBCommons as well (the largest project that was using rbcommons).

Solution

Update documentation and scripts to describe a Github-pull-request-based workflow.

Result

All future review should be accomplished via Github pull requests.

Yasumoto commented 7 years ago

Thanks you two! 👏