search

twitter-archive / diffy

Find potential bugs in your services with Diffy
https://twitter.com/diffyproject
Apache License 2.0
3.83k stars 368 forks source link

Quotes in the README example are not needed #11

Closed thomaska closed 9 years ago

thomaska commented 9 years ago

I tried following the steps described in README.md to try out and test diffy,
but I would get MatchErrors when trying the command: java -jar diffy-server.jar \ -candidate=\"localhost:9992\" \ -master.primary=\"localhost:9990\" \ -master.secondary=\"localhost:9991\" \ -service.protocol=\"http\" \ -serviceName=\"My Service\" \ -proxy.port=:31900 \ -admin.port=:31159 \ -http.port=:31149 \ -rootUrl='localhost:31149' I had to remove the quotes along with the corresponding escape characters for it to work.
I was using a terminal in OS X Yosemite, I don't know if that matters.

mosesn commented 9 years ago

@thomaska does it work if you just remove the escape characters? Like so:

java -jar diffy-server.jar \
-candidate="localhost:9992" \
-master.primary="localhost:9990" \
-master.secondary="localhost:9991" \
-service.protocol="http" \
-serviceName="My Service" \
-proxy.port=":31900" \
-admin.port=":31159" \
-http.port=":31149" \
-rootUrl="localhost:31149"

It should be fine to remove most of the quotes, but I'm surprised that it still works with -serviceName=My Service.

The quotes are used for typical bash string concatenation, they shouldn't be passed to the program.

puneetkhanduri commented 9 years ago

@thomaska Thanks for catching this bug. PR welcome. Care to do the honors and remove the unnecessary escapes?