search

twitter-archive / diffy

Find potential bugs in your services with Diffy
https://twitter.com/diffyproject
Apache License 2.0
3.83k stars 368 forks source link

Add protobuf support to Diffy #29

Closed thinkerou closed 4 years ago

thinkerou commented 8 years ago

diffy is a regression detection system for thrift and http services, so I want it for protobuffer, do I need other? Thanks.

puneetkhanduri commented 8 years ago

@mosesn Is there a recommended way to support protobuf with Finagle?

mosesn commented 8 years ago

Sorry just saw this. We don't use it internally, but finagle/finagle-protobuf is the right way, as far as I know.

puneetkhanduri commented 8 years ago

@thinkerou protobuf is not supported out of the box but it should be possible to do so by leveraging the library mentioned above. Unfortunately, you won't be able to use Diffy without writing the necessary support for protobuf. Let me know if there is interest on your part to make this change.

thinkerou commented 8 years ago

@puneetkhanduri our web server uses protobuf, so I want to use Diffy in order to automated test.

puneetkhanduri commented 8 years ago

@thinkerou Currently, this is not possible. We will have to leave this issue open as a feature request for now.