search

twitter-archive / diffy

Find potential bugs in your services with Diffy
https://twitter.com/diffyproject
Apache License 2.0
3.83k stars 368 forks source link

SSL Support and fix the build #39

Closed gb closed 7 years ago

gb commented 8 years ago

I am trying to use Diffy, but I am facing the same issue that some people have in #21 So the idea of this PR is allow Diffy access APIs under HTTPS.

Basically all the user need to do is specify: "service.protocol=https" and optionally "https.port=xxx" in case of the https port be different than 443.

I don't have much experience with Scala, so let me know if there's a better way to implement it, of if any change is required.

As an extra I updated the travis file to fix the build.

Thank you!

codecov-io commented 8 years ago

Current coverage is 34.91%

Merging #39 into master will decrease coverage by -0.15% as of 432436b

@@            master     #39   diff @@
======================================
  Files           29      29       
  Stmts          790     799     +9
  Branches        41      41       
  Methods          0       0       
======================================
+ Hit            277     279     +2
  Partial          0       0       
- Missed         513     520     +7

Review entire Coverage Diff as of 432436b

Powered by Codecov. Updated on successful CI builds.

puneetkhanduri commented 8 years ago

Thanks for doing this. Just a few minor nits and should be good to merge once I have tested the branch. Again thanks for taking the initiative. Looking forward to more contributions :)

rajatjindal commented 8 years ago

Hi @puneetkhanduri , @gabrielsuch

Can we please merge this pull request. support of https is something that will enable us to start using diffy.

Thanks Rajat Jindal

gb commented 8 years ago

@puneetkhanduri I can remove the httpsPort flag if you prefer, but can we merge it than? I am already using this in production and I am pretty sure a more people are waiting for it.

matth0x1 commented 7 years ago

@puneetkhanduri What's the status on getting https support integrated?

PilchardFriendly commented 7 years ago

This would be really useful to have today. Is there anything stopping the merge?

mgp commented 7 years ago

This would be amazing to have!