search

twitter-archive / diffy

Find potential bugs in your services with Diffy
https://twitter.com/diffyproject
Apache License 2.0
3.83k stars 368 forks source link

Accept application/json without charset #4

Closed coderunner closed 9 years ago

coderunner commented 9 years ago

While testing diffy against a JSON service API, I found out that the JSON lifting is only triggered for application/json; charset="UTF-8" content type.

I used the same trick used for HTML lifting a few lines below and accept plain application/json content type.

coderunner commented 9 years ago

I doubt this failure is due to my changes.

coderunner commented 9 years ago

@puneetkhanduri Updated the commit/PR following your comments.

codecov-io commented 9 years ago

Current coverage is 13.14%

Merging #4 into master will not affect coverage as of 8c54a3a

@@            master      #4   diff @@
======================================
  Files           73      73       
  Stmts         4154    4154       
  Branches       273     430   +157
  Methods          0       0       
======================================
  Hit            546     546       
  Partial          0       0       
  Missed        3608    3608

Review entire Coverage Diff as of 8c54a3a

Powered by Codecov. Updated on successful CI builds.