Open sukalpomitra opened 8 years ago
hi @puneetkhanduri these two tests failed on my local machine too. But I donot know why. The changes I have done should not effect those test cases.
Ok figured out why the test cases were failing. While I was treating the request as HttpRequest the test case was sending string. Added a check to execute my code only when the request is an HttpRequest. Test cases are passing now. Willc ommit soon.
hi @puneetkhanduri I think now the coverage test is failing. Don't understand why from the logs though.
Merging #43 into master will increase coverage by <.01%
- 6 files (not in diff) in
...la/com/twitter/diffy
were modified. more
- Misses
+1
- Hits
-1
@@ master #43 diff @@
==========================================
Files 29 29
Lines 789 850 +61
Methods 772 833 +61
Messages 0 0
Branches 17 17
==========================================
+ Hits 288 311 +23
- Misses 501 539 +38
Partials 0 0
Powered by Codecov. Last updated by 8586972...18507a3
I will try to find some time and do the changes suggested
@sukalpomitra This PR is still open. Did you figure out a different way to send headers? I am trying out diffy and I met with this requirement of sending headers. cc @puneetkhanduri
@savakarv I moved on to other projects and did not have time to fix it. Why dont you fork mine and continue.
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.
:x: sukalpo.mitra
:x: sukalpomitra
You can send different HTTP Header Key value pairs to candidate, primary and secondary servers. Add
-candidateHeaders=Authorization:Basic OtxGHYUI, userRole:admin1 -primaryHeaders=Authorization:Basic NjhmskT, userRole:admin2 -secondaryHeaders=Authorization:Basic Tysfdg, userRole:admin3
to your command line argumentsYou can add apiRoots to the api calls to candidate, primary and secondary servers. Add
-candidateApiRoot="api/v2" -primaryApiRoot="api/v1" -secondaryApiroot="api/v1"
to your command line arguments. Usage:-curl 'localhost:8880/getAllMessages'
will send a requestcandidateServer:candidatePort/api/v2/getAllMessages
to candidate server while it will sendprimaryServer:primaryPort/api/v1/getAllMessages
to primary serverYou can now substitute different queryParam values before multicasting to the three different servers. Usage:-
curl 'localhost:8880/api/getUserMessages?message=userId'
. Create a file apiParams.xml with the following structure `This will send a request
candidateServer:candidatePort/api/getUserMessages?message=12to candidate server while sending
primaryServer:primaryPort/api/getUserMessages?message=13and
secondaryServer:secondaryPort/api/getUserMessages?message=14` request to primary and secondary servers respectively.