Closed davidwrpayne closed 6 years ago
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
Merging #65 into master will decrease coverage by
0.56%
. The diff coverage is7.01%
.
@@ Coverage Diff @@
## master #65 +/- ##
==========================================
- Coverage 35.04% 34.47% -0.57%
==========================================
Files 29 30 +1
Lines 799 815 +16
Branches 34 36 +2
==========================================
+ Hits 280 281 +1
- Misses 519 534 +15
Impacted Files | Coverage Δ | |
---|---|---|
src/main/scala/com/twitter/diffy/Main.scala | 100% <ø> (ø) |
:arrow_up: |
...om/twitter/diffy/proxy/ThriftDifferenceProxy.scala | 0% <ø> (ø) |
:arrow_up: |
.../com/twitter/diffy/proxy/HttpDifferenceProxy.scala | 50% <0%> (ø) |
:arrow_up: |
...om/twitter/diffy/analysis/DifferenceAnalyzer.scala | 0% <0%> (ø) |
|
...m/twitter/diffy/analysis/DifferenceCollector.scala | 1.85% <1.85%> (+1.85%) |
:arrow_up: |
...ain/scala/com/twitter/diffy/util/EmailSender.scala | 94.44% <100%> (ø) |
:arrow_up: |
...n/scala/com/twitter/diffy/DiffyServiceModule.scala | 100% <100%> (ø) |
:arrow_up: |
...in/scala/com/twitter/diffy/lifter/HttpLifter.scala | 100% <100%> (ø) |
:arrow_up: |
...diffy/analysis/RedisStoreDifferenceCollector.scala | 21.42% <21.42%> (ø) |
|
...cala/com/twitter/diffy/proxy/DifferenceProxy.scala | 25.92% <50%> (ø) |
:arrow_up: |
... and 2 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f307e3f...ece4949. Read the comment docs.
Accidental pr. Feel free to ignore