Open ghost opened 6 years ago
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
Merging #72 into master will decrease coverage by
0.6%
. The diff coverage is5.88%
.
@@ Coverage Diff @@
## master #72 +/- ##
==========================================
- Coverage 35.04% 34.43% -0.61%
==========================================
Files 29 30 +1
Lines 799 816 +17
Branches 34 34
==========================================
+ Hits 280 281 +1
- Misses 519 535 +16
Impacted Files | Coverage Δ | |
---|---|---|
...ain/scala/com/twitter/diffy/lifter/XmlLifter.scala | 0% <0%> (ø) |
|
...in/scala/com/twitter/diffy/lifter/HttpLifter.scala | 86.2% <11.11%> (-13.8%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 7894459...9b2d671. Read the comment docs.
We need to compare xml responses, therefore I wrote a XmlLifter which simply converts the xml to json.