Open ghost opened 6 years ago
Merging #73 into master will increase coverage by
0.23%
. The diff coverage is71.42%
.
@@ Coverage Diff @@
## master #73 +/- ##
==========================================
+ Coverage 35.04% 35.27% +0.23%
==========================================
Files 29 29
Lines 799 805 +6
Branches 34 34
==========================================
+ Hits 280 284 +4
- Misses 519 521 +2
Impacted Files | Coverage Δ | |
---|---|---|
.../com/twitter/diffy/proxy/HttpDifferenceProxy.scala | 46.15% <0%> (-3.85%) |
:arrow_down: |
...n/scala/com/twitter/diffy/DiffyServiceModule.scala | 100% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 7894459...2f11c3d. Read the comment docs.
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
Some of our services produce rather big responses, bigger than the default of 5 megabytes. So I added two additional settings which are used in the serviceFactory to create the http clients.