search

twitter-archive / kestrel

simple, distributed message queue system (inactive)
http://twitter.github.io/kestrel
Other
2.78k stars 313 forks source link

Multiple open transactions on a connection #129

Closed banker closed 10 years ago

banker commented 10 years ago

https://github.com/robey/kestrel/blob/master/src/main/scala/net/lag/kestrel/MemcacheHandler.scala#L187-L192

According to the docs, Kestrel is supposed to allow only one open transaction per connection per queue. But in the highlighted code above, the error response will never be generated in the case where opening == true and handler.countPendingReads(key) > 0 because of the final !opening clause.

Is this expected?

banker commented 10 years ago

commit e7a39d7c57595b2234a92856d56ec1d5f86bf515 Ah. I just found the commit where this restriction was removed:

Author: Robey Pointer robey@twitter.com Date: Thu Oct 28 16:01:26 2010 -0700

pass the QueueCollection through to KestrelHandler so it's less tightly coupled. remove the restriction on "one outstanding transaction per connection"

I'll submit a pull request for a documentation update.