search

twitter-archive / kestrel

simple, distributed message queue system (inactive)
http://twitter.github.io/kestrel
Other
2.77k stars 312 forks source link

Journal not rolled when all removes are transactional #13

Closed ebarlas closed 14 years ago

ebarlas commented 14 years ago

PersistentQueue.remove only rolls the journal if the queue length = 0, journal size >= max journal size, AND open transactions = 0. This will never occur if all removes are transactional and rolling will only occur when the journal size > max journal size * journal overflow. Perhaps a similar check should be performed if the queue length is 0 and nothing is removed? Or perhaps the journal should be rolled even is there are open transactions?

ebarlas commented 14 years ago

Hmm, I just looked at the history for PersistentQueue and apparently you fixed this. Why is this not part of the most recent build?

ebarlas commented 14 years ago

Closing.

robey commented 14 years ago

i haven't made a release in a while -- my bad. i'll do that soon.