scripts/kestrel.sh VERSION is old

twitter-archive / kestrel

simple, distributed message queue system (inactive)

http://twitter.github.io/kestrel

Other

2.77k stars 312 forks source link

Closed tenorviol closed 14 years ago

tenorviol commented 14 years ago

Downloaded Kestrel v1.2. The example startup script scripts/kestrel.sh is on version:

VERSION="1.1.1"

This provided a minor bit of confusion for me (a kestrel noob). Suggest using ant to keep the version here current.

twitter commented 14 years ago

it looks like it's 1.2 in head (but the version has bumped to 1.2.1, so i fixed that again).

how could ant help here? i'd love if there was some way. :) though i've pretty much migrated to sbt now.

robey commented 14 years ago

oops, that was me (robey) not twitter. :)

tenorviol commented 14 years ago

This may not be relevant given the migration to sbt. I was looking at this fragment in ant/package.xml:

This made me think you might add a:

<filter token="VERSION" value="${where.the.damn.version.is}" />

And modify scripts/kestrel.sh with:

VERSION="@VERSION@"

Or something. It's an idea. Could be crap.

robey commented 14 years ago

good idea -- done! :)