twitter-archive / kestrel

simple, distributed message queue system (inactive)
http://twitter.github.io/kestrel
Other
2.77k stars 312 forks source link

expiration for items is in milliseconds instead of seconds #31

Closed matterkkila closed 13 years ago

matterkkila commented 13 years ago

The docs say "When they come from a client, expiration times are handled in the same way as memcache: if the number is small (less than one million), it's interpreted as a relative number of seconds from now. Otherwise it's interpreted as an absolute unix epoch time, in seconds since the beginning of 1 January 1970 GMT."

But based on my testing of setting a timeout of 3600, which should be 1 hour, it actually times out rather quickly, looking into the code I don't see where the expiry is multiplied by 1000 to convert it to ms before it gets normalized in QueueCollection:add().

robey commented 13 years ago

thanks -- applied!