may be a bug . in Jouranl.scala

[Nyu2Y]

when queueConfig.sycnJournal not equal 0.seconds or Duration.maxValue, Journal will not work PersistentQueueSpec will stop at queue.remove , and not retrun . because :

• in kestrel / src / main / scala / net / lag / kestrel / Journal.scala  line:471  val future = writer.write(byteBuffer)     if (allowSync) future()
  future with "()" , it will wait for result to call apply , but in kestrel / src / main / scala / net / lag / kestrel / PeriodicSyncFile.scala <line: 60> promise is without promise.setValue(()) .

change
kestrel / src / main / scala / net / lag / kestrel / Journal.scala  line:471 if (allowSync) future() to if (allowSync) future it seems work well .

I am not familiar with promise , please check it . wait your comment .

[robey]

if syncJournal is not 0 or max, the promise should be added to the "promise list" (promises). then the periodic timer on line 20 will call fsync, which sets the promise values on line 31.

[Nyu2Y]

i have a problem , why 'if (allowSync) future() ' futrue with ''()''?

whats the different between future() and future at in kestrel / src / main / scala / net / lag / kestrel / Journal.scala line:471

[robey]

future() causes it to block, waiting for the future to be fulfilled.