twitter-archive / kestrel

simple, distributed message queue system (inactive)
http://twitter.github.io/kestrel
Other
2.77k stars 312 forks source link

Add version, stats and dump stats to text protocol. Sorta kinda test it... #55

Closed gphat closed 13 years ago

gphat commented 13 years ago

I tested the new response class I made, but I didn't know see an example of the version/stats/dump_stats to see how to properly test that. I'm not really a Scala guy, but I can copy it and adapt it a bit. ;)

That response class might be a bad idea.

I'm sure blatantly copying the stats and dump_stats code from the other handler is a bad idea, since it should likely be put in some common place.

This might not be useful, but I thought I'd send it along. Thanks either way!

gphat commented 13 years ago

Ping? :)

robey commented 13 years ago

i guess i really only want "version" from here. i want to keep the stats on the admin/stats port. i'll copy the "version" bit manually but still give you credit. :)

robey commented 13 years ago

done!

gphat commented 13 years ago

Thanks!