search

twitter-archive / kestrel

simple, distributed message queue system (inactive)
http://twitter.github.io/kestrel
Other
2.77k stars 312 forks source link

Clearing Deleted Queue Stats #66

Closed gphat closed 13 years ago

gphat commented 13 years ago

How do you feel about clearing out stats for queues that have been deleted? Looks like there'd just need to be a Stats.clearGuage (or whatever stat type there is) added to the code at the time of deletion.

I'm happy to give this a go, but wanted to get a read from you on this being the direction you'd want to go. Our instance of kestrel handles a lot of transient queues that we delete, but their stats are causing the stats calls to ostrich to be huge.

robey commented 13 years ago

that change sounds great to me!

gphat commented 13 years ago

Excellent.

I've sent a pull request for ostrich, as there was no clearCounter method. I've also pushed a partial fix to my stats-clear branch that handles the clear of the gauge stats.

As an aside I noticed that this doesn't clear any of the gauges from the /graph/ stuff. I'll have to look into that.

robey commented 13 years ago

renamed it to removeCounter (because clearing a counter already has a meaning) and merged!

gphat commented 13 years ago

Cool, thanks Robey!

When do you plan to bring that ostrich version over to kestrel?

robey commented 13 years ago

just merged it in now, and your branch -- i refactored it a bit to keep all the counter/gauge code in PersistentQueue.