FIX : Return YES if the SSO login isMobileSSOSuccess

twitter-archive / twitter-kit-ios

Twitter Kit is a native SDK to include Twitter content inside mobile apps.

Apache License 2.0

690 stars 449 forks source link

FIX : Return YES if the SSO login isMobileSSOSuccess #109

Open leverdeterre opened 5 years ago

leverdeterre commented 5 years ago

Problem

I was not able to properly finalize a login with a Twitter account using Firebase. The Twitter login is actually impossible to enable with the FirebaseUI auth providers. I noticed an error in your management of OpenUrl in the application delegate

Solution

Say YES when TwitterKit is challenged to open an URL and the SSO is a success. TwitterKit has done the job!

Result

Avoid a crash on the providers loop on the Firebase UI SDK because the SDK will try to find a provider to handle the asked openUrl and your SDK has complete the job 👍

CLAassistant commented 5 years ago

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Jérôme Morissard seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

ducnv2910 commented 5 years ago

Please merge it soon. because it doesn't work on swift 4.2

NathanWalker commented 5 years ago

Hi @leverdeterre would you mind sharing how you built this locally? Having trouble building directly from your repo.