Open leverdeterre opened 5 years ago
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
Please merge it soon. because it doesn't work on swift 4.2
Hi @leverdeterre would you mind sharing how you built this locally? Having trouble building directly from your repo.
Problem
I was not able to properly finalize a login with a Twitter account using Firebase. The Twitter login is actually impossible to enable with the FirebaseUI auth providers. I noticed an error in your management of OpenUrl in the application delegate
Solution
Say YES when TwitterKit is challenged to open an URL and the SSO is a success. TwitterKit has done the job!
Result
Avoid a crash on the providers loop on the Firebase UI SDK because the SDK will try to find a provider to handle the asked openUrl and your SDK has complete the job 👍