search

twitter-archive / twitter-kit-ios

Twitter Kit is a native SDK to include Twitter content inside mobile apps.
Apache License 2.0
688 stars 449 forks source link

Manual twitterkit installation instructions are wrong #110

Open guylando opened 5 years ago

guylando commented 5 years ago

The instructions are wrong: https://github.com/twitter/twitter-kit-ios/wiki/Installation#install-twitter-kit-manually The correct installation is to add TwitterKit and TwitterKitCore to embedded binaries and add TwitterKit to linked libraries. For cordova this can be done using this code: https://github.com/guylando/twitterkit3-plugin/blob/master/plugin.xml#L61

Explanation:

  1. TwitterKit.framework and TwitterCore.framework must be embedded or otherwise there is a runtime dyld missing library error
  2. Must not link TwitterCore.framework or otherwise will get the runtime warnings discribed here: https://github.com/twitter/twitter-kit-ios/issues/91, https://github.com/twitter/twitter-kit-ios/issues/18
tolgahan-arikan commented 5 years ago

thanks, this works!

tolgahan-arikan commented 5 years ago

Ahh, actually this didn't help with one of the errors on CI, private submodule 'TwitterCore.Private' in private module map, expected top-level module. Sorry for bothering but do you know anything about this error @guylando?

guylando commented 5 years ago

And this error prevents your oauth from working? My oauth works well after the fix inside cordova app (android + ios)