search

twitter-archive / twitter-kit-ios

Twitter Kit is a native SDK to include Twitter content inside mobile apps.
Apache License 2.0
689 stars 449 forks source link

Fix modal-on-modal dismiss bug #23

Closed inamiy closed 6 years ago

inamiy commented 6 years ago

There is a minor UI bug when performWebBasedLogin is called from modal view controller.

For example, when SFSafariViewController (login screen, modal-on-modal) gets cancelled, dismiss is eventually called on safari's presentingViewController, not safari itself. This will eventually dismiss both modals at the same time.

Please see repro code for more detail (comments are included): https://github.com/inamiy/twitter-kit-ios/commit/04b74159b648e1ff642fb6819b429e85b78105b9

CLAassistant commented 6 years ago

CLA assistant check
All committers have signed the CLA.

inamiy commented 6 years ago

Notifced that this fix will solve:

rajul-arora commented 6 years ago

Hi @inamiy we already have a fix for this internally and it will be included in the next release of TwitterKit! Thanks for taking the time to put up a fix for this!

inamiy commented 6 years ago

@rajul-arora Great! Please bump the binary ASAP. (Using forked version with package manager is currently very hard to use)

JacobJT commented 6 years ago

I wouldn't call this a minor bug, it's a pretty major bug, particularly because the error handler doesn't even get called if the Twitter app isn't installed.

It looks like a fix has been pending for a while... can we get a new release soon?

inamiy commented 6 years ago

Discontinuing Support for Twitter Kit SDK 😇