search

twitter-archive / twitter-kit-ios

Twitter Kit is a native SDK to include Twitter content inside mobile apps.
Apache License 2.0
690 stars 448 forks source link

TWTRTimelineViewController impossible to dismiss image #41

Closed ghost closed 6 years ago

ghost commented 6 years ago

TWTRTimelineViewController impossible to dismiss image

Expected behavior

Tap on single tweets' image -> show image in modal view -> dismiss tapping on "X" button

Actual behavior

It's impossible to tap on "X" because of UI issue:

simulator screen shot - iphone x - 2018-03-09 at 12 36 41

Steps to reproduce the behavior

Tap on single tweets' image

nbonamy commented 6 years ago

+1 even in single tweet display

jessedijkstra commented 6 years ago

+1 even less clear on a white bar picture 35

walsht commented 6 years ago

+1, anyway we can adjust that close image color?

katejlee commented 6 years ago

The patch to fix this issue has been added to internal repo. We will be releasing final version in next few weeks.