search

twitter-archive / twitter-text-js

A JavaScript implementation of Twitter's text processing library
1.21k stars 166 forks source link

link @ in @name #125

Open jakl opened 10 years ago

jakl commented 10 years ago

@KL-7 or @jugyo could you review? Whenever you have time. INTL-5848

jakl commented 10 years ago

I'll push the latest conformance submodule to make Travis CI succeed.

jakl commented 10 years ago

Looks like the git submodule command isn't compatible with git@... url's. I'll revert that. It is highly convenient locally for committing edits in a submodule - too bad...

KL-7 commented 10 years ago

:shipit:

jakl commented 10 years ago

Thanks! I might have another minor change here - then I'll update Java, Ruby, Objc, Conformance - then shipit and publish. 8)

timhaines commented 10 years ago

@jakl Nice work. Is the other minor change fixing the tweet character botching? https://github.com/twitter/twitter-text-js/pull/122

jugyo commented 10 years ago

Good job :)

thiagogds commented 10 years ago

:+1:

rodrigopinto commented 10 years ago

:+1: Any idea when it would be merged?

kush-patel-hs commented 7 years ago

👍 please merge

CLAassistant commented 4 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.