search

twitter-dart / twitter-api-v2

The most famous and powerful Dart/Flutter library for Twitter API v2.0 🐦
https://pub.dev/packages/twitter_api_v2
BSD 3-Clause "New" or "Revised" License
167 stars 45 forks source link

Feature Request: `TwitterApi.lists.lookupTweets` is missing some arguments such as mediaFields. #663

Closed ywake closed 1 year ago

ywake commented 1 year ago

1. Problem to solve

I want to specify mediaField, but currently it is not possible.

2. Proposal

Please add arguments as with other lookupTweets!

3. More information

github-actions[bot] commented 1 year ago

Thanks for your contribution! :)

myConsciousness commented 1 year ago

Hi @ywake ,

This is good feedback! I seem to have been looking and this argument.

I just can't confirm that it works because I already have an expired token to use the Twitter API.

Can you create a PR? Add List<MediaField>? mediaFields to the following abstract method.

https://github.com/twitter-dart/twitter-api-v2/blob/712cc1ded6658094043aa7795609b58b0f64f9c1/lib/src/service/lists/lists_service.dart#L420

And then add implementation like below.

https://github.com/twitter-dart/twitter-api-v2/blob/712cc1ded6658094043aa7795609b58b0f64f9c1/lib/src/service/lists/lists_service.dart#L1233

https://github.com/twitter-dart/twitter-api-v2/blob/712cc1ded6658094043aa7795609b58b0f64f9c1/lib/src/service/lists/lists_service.dart#L1249

ywake commented 1 year ago

Roger that! I have created a pull request. #664

github-actions[bot] commented 1 year ago

This issue is stale because it has been open for 30 days with no activity.

github-actions[bot] commented 1 year ago

This issue was closed because it has been inactive for 7 days since being marked as stale.