perform log scaling in add_formatted_y() instead of using coord_trans()

twitter / AnomalyDetection

Anomaly Detection with R

GNU General Public License v3.0

3.56k stars 779 forks source link

perform log scaling in add_formatted_y() instead of using coord_trans() #12

Closed ahardjasa closed 9 years ago

ahardjasa commented 9 years ago

Issue #9. Put the y log transformation into the add_formatted_y function rather than as its own line to prevent overwriting the y-axis formatting. I also had to add some logic into get_range so that it can set an appropriate (i.e. >0) minimum when y_log is being used, hope that's okay.

akejariwal commented 9 years ago

@ahardjasa We have reviewed your patch and it looks good. However, apparently (as you can see), there are conflicts due to which automatic merge is not allowed. Can you please address the same and resubmit the patch. Thanks.

cc @owenvallis @jhochenbaum

ahardjasa commented 9 years ago

@akejariwal Does this work now? Apologies, I am pretty new to git/pull requests.

akejariwal commented 9 years ago

Thanks @ahardjasa. Incidentally, @jhochenbaum merged your changes and submitted a PR. Once the Travis CI passes, I shall merge. Thanks again for your contribution.