search

twitter / AnomalyDetection

Anomaly Detection with R
GNU General Public License v3.0
3.55k stars 776 forks source link

Issue 20: Issues using daily data with the "long_term" option #21

Closed cozos closed 9 years ago

cozos commented 9 years ago
  1. Added a parameter(piecewise_median_period_weeks) that specifies the piecewise median time windows which was previously defaulted to 2 weeks.
  2. Added an error message if max_outliers = 0 in a time window, prompting the user to choose a higher piecewise_median_period_weeks.
  3. Made the time period passed to detect_anoms 2 x num_obs_per_period + 1 instead of 2 x num_obs_per_period.
jhochenbaum commented 9 years ago

Thanks a lot @cozos -- sounds good, I'm going to do a review shortly.

Best,

owenvallis commented 9 years ago

Hi @cozos, thanks again for the changes. The code looks solid except for an extra parenthesis on line 43 in detect_anoms.R. Once you remove it we can merge in the changes.

Best,

akejariwal commented 9 years ago

@cozos The Traviz CI build failed. Please have a look at the Details and submit a new PR.

cc @owenvallis @jhochenbaum

cozos commented 9 years ago

Hey, sorry for the sloppiness! I had neglected to check my notifications