search

twitter / AnomalyDetection

Anomaly Detection with R
GNU General Public License v3.0
3.55k stars 776 forks source link

consistent output for AnomalyDetectionTs() #39

Open Mullefa opened 9 years ago

Mullefa commented 9 years ago

If there are no anomalies detected then list(anoms = NULL, plot = NULL) is returned. Does this special case need to be made? Instead could a data frame (with 0 rows) and a plot (if plot = TRUE) still be returned for consistency?

terrytangyuan commented 9 years ago

@akejariwal do you think this is necessary? If so, I am happy to jump in and help make the changes.

akejariwal commented 9 years ago

@terrytangyuan It's not core to the package. Having said that, I encourage you to submit a patch.

Mullefa commented 9 years ago

A bit of context: consistent output facilitates building shiny applications, and I can imagine this package being used in conjunction with shiny.

terrytangyuan commented 8 years ago

Could anyone close this? Thanks.