search

twitter / AnomalyDetection

Anomaly Detection with R
GNU General Public License v3.0
3.55k stars 776 forks source link

fixed bug and added error handling when there are NAs in timestamp #51

Closed terrytangyuan closed 9 years ago

terrytangyuan commented 9 years ago

Currently, if there's NA in timestamp, R will give the following error:

Error in if (gran >= 86400) { : missing value where TRUE/FALSE needed

However, it is too hard for the user to know what the problem is, at least for me, I don't know where to fix the problem. I think this error handling is needed so that user knows where to go from here.

terrytangyuan commented 9 years ago

See this issue #28 I didn't notice someone else had this issue. It took the users a while to figure out the problem. They'll have to dig into the code to see how to fix it.

akejariwal commented 9 years ago

@caniszczyk I approve this PR. Please merge.

terrytangyuan commented 9 years ago

Could you merge this as well? Thanks.

terrytangyuan commented 9 years ago

Thanks Chris. On Aug 31, 2015 4:11 PM, "Chris Aniszczyk" notifications@github.com wrote:

Merged #51 https://github.com/twitter/AnomalyDetection/pull/51.

— Reply to this email directly or view it on GitHub https://github.com/twitter/AnomalyDetection/pull/51#event-397065879.