search

twitter / AnomalyDetection

Anomaly Detection with R
GNU General Public License v3.0
3.55k stars 776 forks source link

Fix e_value error with dates #53

Closed odinuv closed 5 years ago

odinuv commented 9 years ago

Fix for issue #46. The issue raises when dates without time portion are supplied

akejariwal commented 9 years ago

@odinuv Does the change (POSIXlt -> POSIXct) work well with plotting? Did you test it?

CC @owenvallis @jhochenbaum

owenvallis commented 9 years ago

I just merged in his changes into my local repo and ran all the tests. The package ran fine, and all of the plots look great. Looking at the code, it seems all good to go.

On Tue, Aug 4, 2015 at 6:28 AM, Arun Kejariwal notifications@github.com wrote:

@odinuv https://github.com/odinuv Does the change (POSIXlt -> POSIXct) work well with plotting? Did you test it?

CC @owenvallis https://github.com/owenvallis @jnatanh

— Reply to this email directly or view it on GitHub https://github.com/twitter/AnomalyDetection/pull/53#issuecomment-127410385 .

Owen Vallis, Ph.D. Professor of Music Technology: Intelligence, Interaction, and Design (MTIID) California Institute of the Arts http://www.flipmu.com

akejariwal commented 9 years ago

@caniszczyk I approve the PR. Please merge.

jhochenbaum commented 8 years ago

@akejariwal seems like we still need to et this merged in

akejariwal commented 8 years ago

@caniszczyk Please merge this PR.

dougmitarotonda commented 7 years ago

Is there any update on when this will be merged?