Closed odinuv closed 5 years ago
@odinuv Does the change (POSIXlt -> POSIXct) work well with plotting? Did you test it?
CC @owenvallis @jhochenbaum
I just merged in his changes into my local repo and ran all the tests. The package ran fine, and all of the plots look great. Looking at the code, it seems all good to go.
On Tue, Aug 4, 2015 at 6:28 AM, Arun Kejariwal notifications@github.com wrote:
@odinuv https://github.com/odinuv Does the change (POSIXlt -> POSIXct) work well with plotting? Did you test it?
CC @owenvallis https://github.com/owenvallis @jnatanh
— Reply to this email directly or view it on GitHub https://github.com/twitter/AnomalyDetection/pull/53#issuecomment-127410385 .
Owen Vallis, Ph.D. Professor of Music Technology: Intelligence, Interaction, and Design (MTIID) California Institute of the Arts http://www.flipmu.com
@caniszczyk I approve the PR. Please merge.
@akejariwal seems like we still need to et this merged in
@caniszczyk Please merge this PR.
Is there any update on when this will be merged?
Fix for issue #46. The issue raises when dates without time portion are supplied