Open shahkushan1 opened 10 years ago
@shahkushan1 Thanks for your interest in the package. Extending the plotting support in the package is very much welcome. In addition to the horizontal lines corresponding to the respective means, we would like to retain the currently supported vertical lines (may be of different type and in different color than the horizontal lines). Also, the ylabel should default to 'count' and, for better readability, it would be good to have the yticks read 10K/20K/... for values in thousands, 10M/20M/... for values in millions, 10B/20B/...for values in billions and so and so forth.
cc @putnam120
Thanks @akejariwal. I will definitely update the plots with annotations as suggested. Can we retain both the plotting styles and allow the user to select them via some argument?
@shahkushan1 Are you suggesting to also support raw values for yticks? If so, the raw values will eat a lot of real estate and the plot will look ugly. At Twitter, we use the short form by default.
I guess I misread your previous comment. Will definitely make the suggested improvements in the plot.
Please can anyone help me with how to get the new figure plot style by shahkushan1
Thanks for building and open sourcing the package. I've found that the default plot generated does not allow the viewer to easily compare the mean shifts across different time periods and gauge the magnitude of the shift. The example plot shown in the blog works well for this particular use-case.
I've been able to modify the plotting section in EDM.R to produce this plot instead of the default one
If you think this use-case is potentially useful to other users of the package, would you accept a PR?