twitter / GraphJet

GraphJet is a real-time graph processing library.
Apache License 2.0
713 stars 111 forks source link

Add unfavorite edge processing in hashtag/url path #107

Closed guimingTang closed 6 years ago

guimingTang commented 6 years ago

This is yet another follow up change set to add unfavorite edge indexing in GraphJet, this time we add this functionality for Hashtag/Urls. In the tweet counting algorithms, tweet, hashtag, and urls all share the same graph traversal logic, i.e. they all collect and index unfavorite edges. However, during candidate generation, tweet and hashtag/url have a separate code paths. We previously patched up the tweet code path, but neglected hashtag/urls. This request consolidates the unfavorite logic in one place, i.e. GeneratorHelper.java. Also added new tests to cover hashtag/urls.

CLAassistant commented 6 years ago

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


gtang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.