Create a composite filter for logic AND

twitter / GraphJet

GraphJet is a real-time graph processing library.

Apache License 2.0

713 stars 111 forks source link

Create a composite filter for logic AND #70

Closed guimingTang closed 7 years ago

guimingTang commented 7 years ago

GraphJet's ResultFilterChain applies filter in disjunction, a.k.a logical OR. We need to also allow filters to apply in conjunction, a.k.a logical AND. This request addresses this. In addition, we also added a new filter that filters based on the exact number of user social proofs for each candidate.

In this request:

Added a new filter type to apply logical AND to multiple filters
Added a new filter to only pass candidates with the exact number of user social proofs specified

guimingTang commented 7 years ago

A short summary of the changes in the recent several new commits:

Added more test cases, especially for TweetAuthorFilter
Modified behavior in TweetAuthorFilter when an empty author list is passed in. By default, it will now filter nothing if given a empty author set.

guimingTang commented 7 years ago

In response to Jerry's comments, I added more comments to describe the behavior of each new filter.